Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bexley][WW] Allow user to request new containers #5111

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Aug 14, 2024

This is the 'base' branch for code for Bexley's container maintenance project (https://github.com/mysociety/societyworks/milestone/116) before putting everything live.

[skip changelog]

@nephila-nacrea nephila-nacrea self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 96.05735% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (182f35b) to head (25f375b).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 95.73% 4 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
+ Coverage   82.41%   82.96%   +0.54%     
==========================================
  Files         409      410       +1     
  Lines       32073    33272    +1199     
  Branches     5118     5459     +341     
==========================================
+ Hits        26432    27603    +1171     
- Misses       4122     4140      +18     
- Partials     1519     1529      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nephila-nacrea nephila-nacrea changed the title WIP [Bexley][WW] Allow user to request new containers [Bexley][WW] Allow user to request new containers Oct 23, 2024
@nephila-nacrea nephila-nacrea marked this pull request as ready for review October 23, 2024 18:08
@dracos dracos force-pushed the bexley-ww-container-requests branch 2 times, most recently from 99bbc13 to 41457d7 Compare October 30, 2024 16:46
@dracos dracos force-pushed the bexley-ww-container-requests branch from 82e1602 to 903aff9 Compare November 1, 2024 10:43
@dracos dracos force-pushed the bexley-ww-container-requests branch 2 times, most recently from cec6990 to 68a3ded Compare November 5, 2024 12:48
@dracos dracos force-pushed the bexley-ww-container-requests branch from 68a3ded to 5bb8860 Compare November 5, 2024 13:19
nephila-nacrea and others added 19 commits November 11, 2024 19:50
Also renamed final 'submit' to reflect that request is not just
for new containers.
…form

We had not handled cases where the container has a 'parent' (i.e. wheelie
bin with different size options), nor handled removal options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants